Skip to content

ping4:Set the filter for reply packet. #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
13627105546 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ping4:Set the filter for reply packet. #3316

13627105546 wants to merge 1 commit into from
+18 −0

Conversation

@13627105546
Copy link
Contributor

@13627105546 13627105546 commented Jan 13, 2026

Note: Please adhere to Contributing Guidelines.

Summary

  • Why : When using icmp_ping , there is no filter set for the socket. This might cause the socket to receive unwanted ICMP packets or fail to filter out packets that are not Echo Replies, potentially interfering with the ping logic or causing performance issues in noisy network environments.
  • What : This commit adds logic to set the ICMP_FILTER socket option for the ping socket. It introduces a macro ICMP_SET_FILTER and uses setsockopt to configure the filter to only allow ICMP_ECHO_REPLY packets, blocking all other ICMP types.

Impact

  • Users : Users of the ping command will experience more robust behavior as the socket will only process relevant ICMP Echo Reply packets.
  • Build : No impact on build configuration.
  • Hardware : No specific hardware dependency. Depends on the TCP/IP stack implementation of ICMP_FILTER socket option.
  • Compatibility : Backward compatible.

Testing

  • Verification :
  • Verified that the code compiles successfully.
  • Verified that checkpatch.sh passes for the modified files.
  • Target : Verified on local hardware platform.

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Jan 13, 2026

@13627105546 fix:

d8a9600bc ping4:Set the filter for reply packet.
../nuttx/tools/checkpatch.sh -c -u -m -g b0b90ac72886a7d2ee8d9a16e057a4b2c801984e..HEAD
❌ Remove Gerrit Change-ID's before submitting upstream
Used config files:

@13627105546
Copy link
Contributor Author

13627105546 commented Jan 13, 2026

@13627105546 fix:

d8a9600bc ping4:Set the filter for reply packet.
../nuttx/tools/checkpatch.sh -c -u -m -g b0b90ac72886a7d2ee8d9a16e057a4b2c801984e..HEAD
❌ Remove Gerrit Change-ID's before submitting upstream
Used config files:

have been remove Change-ID with commits

@simbit18
Copy link
Contributor

simbit18 commented Jan 13, 2026

@13627105546 please fix

../nuttx/tools/checkpatch.sh -c -u -m -g b0b90ac72886a7d2ee8d9a16e057a4b2c801984e..HEAD
❌ Missing git commit message
Used config files:
    1: .codespellrc
Some checks failed. For contributing guidelines, see:
  https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
Error: Process completed with exit code 1.

@13627105546
Copy link
Contributor Author

13627105546 commented Jan 13, 2026

@13627105546 please fix

../nuttx/tools/checkpatch.sh -c -u -m -g b0b90ac72886a7d2ee8d9a16e057a4b2c801984e..HEAD
❌ Missing git commit message
Used config files:
    1: .codespellrc
Some checks failed. For contributing guidelines, see:
  https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
Error: Process completed with exit code 1.

Done, have been add git commit message

xiaoxiang781216
xiaoxiang781216 reviewed Jan 14, 2026
View reviewed changes
netutils/ping/icmp_ping.c Outdated
****************************************************************************/

#define ICMP_IOBUFFER_SIZE(x) (sizeof(struct icmp_hdr_s) + (x))
#define ICMP_SET_FILTER(t) (UINT32_MAX - (1U << (t)))
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why sub UINT32_MAX

Copy link
Contributor Author

@13627105546 13627105546 Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I have updated the macro to use bitwise NOT (~(1U << (t))) as suggested

@liqinhuixm @13627105546
netutils/ping: Support ICMP filter for ping.
9d80355 
Add setsockopt support to filter ICMP packets.

Signed-off-by: liqinhui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Area: Networking Size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@13627105546 @xiaoxiang781216 @simbit18 @liqinhuixm